Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Native Contracts to be updated #2942

Merged
merged 64 commits into from
Feb 23, 2024
Merged

Allow Native Contracts to be updated #2942

merged 64 commits into from
Feb 23, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Nov 5, 2023 •
edited
Loading

Close #2932
Can be tested with #2925

@shargon shargon marked this pull request as ready for review November 5, 2023 14:15
@Jim8y
Copy link
Contributor

Jim8y commented Nov 6, 2023

@shargon does this native update still require a resync?

vncoelho
vncoelho reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started reviewing, @shargon,
The changes looks good and compact.

I still did not reach the part where we can call functions from previous versions while re-syncing. Can you pin that for me?
I will soon be back to the code and, then, test it. It will require some good attention.

@vncoelho vncoelho mentioned this pull request Nov 6, 2023
Merged
@shargon
Copy link
Member Author

shargon commented Nov 6, 2023

@shargon does this native update still require a resync?

In this version I think that is not required. But I want to remove currentAllowedMethods and I think that we can do it better changing the current offsets and native scripts.

@shargon shargon mentioned this pull request Nov 6, 2023
Merged
@shargon
Copy link
Member Author

shargon commented Feb 19, 2024

@superboyiii I think that now it's solved :) sorry for all!

@superboyiii
Copy link
Member

@superboyiii I think that now it's solved :) sorry for all!

Nice, let me retest it.

@superboyiii
Copy link
Member

superboyiii commented Feb 20, 2024 •
edited
Loading

Can we make a draft to fix neo-project/neo-modules#874 ? this breaks me for testing.

@superboyiii
Copy link
Member

superboyiii commented Feb 21, 2024 •
edited
Loading

@shargon Tested with #3149, When arriving the fork height for HF_Cockatrice, consensus throw exception when executing SYSCALL System.Contract.NativeOnPersist

62678fb2a5d621b5a5783d04f24797a
960d7d74ca40d4414a1ba005dca42b6
2c09558970e13285da3db16518792f6

@shargon
Copy link
Member Author

shargon commented Feb 21, 2024

@superboyiii I promise that now it will work :)

@superboyiii
Copy link
Member

@shargon All feature works well on my privatenet now. To ensure everything compatible, I will re-check storage on mainnet. Give me 1 more day.

@shargon shargon added the blocker Issues that are blocking other issues. Check issues details to see what it is blocking. label Feb 22, 2024
@shargon
Copy link
Member Author

shargon commented Feb 22, 2024

@neo-project/core is reviewed?

This was referenced Feb 22, 2024
Closed
Merged
vncoelho
vncoelho approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I reviewed I think it is not changed

@shargon
Copy link
Member Author

shargon commented Feb 23, 2024

@superboyiii ready?

superboyiii
superboyiii approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@superboyiii superboyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainnet data is compatible.

@shargon shargon merged commit b467613 into master Feb 23, 2024
7 checks passed
@shargon shargon deleted the update-native-contracts branch February 23, 2024 11:31
@roman-khimov roman-khimov mentioned this pull request Mar 4, 2024
Closed
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 9, 2024
@AnnaShaleva
native: emit Deploy/Update notifications on native deploy/update
f087bde 
Ported as a part of neo-project/neo#2942.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 9, 2024
@AnnaShaleva
native: emit Deploy/Update notifications on native deploy/update
0a01f05 
Ported as a part of neo-project/neo#2942.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva mentioned this pull request Apr 13, 2024
Merged
10 tasks
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 18, 2024
@AnnaShaleva
native: emit Deploy/Update notifications on native deploy/update
c9955ff 
Ported as a part of neo-project/neo#2942.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 18, 2024
@AnnaShaleva
native: emit Deploy/Update notifications on native deploy/update
146f3de 
Ported as a part of neo-project/neo#2942.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 18, 2024
@AnnaShaleva
native: emit Deploy/Update notifications on native deploy/update
c7969ea 
Ported as a part of neo-project/neo#2942.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva mentioned this pull request Apr 24, 2024
Closed
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 25, 2024
@AnnaShaleva
native: emit Deploy/Update notifications on native deploy/update
73c742a 
Ported as a part of neo-project/neo#2942.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov left review comments

@AnnaShaleva AnnaShaleva AnnaShaleva left review comments

@vncoelho vncoelho vncoelho approved these changes

@superboyiii superboyiii superboyiii approved these changes

@Jim8y Jim8y Awaiting requested review from Jim8y

Assignees
No one assigned
Labels
blocker Issues that are blocking other issues. Check issues details to see what it is blocking. critical Issues (bugs) that need to be fixed ASAP waiting for review
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

Fix/Allow Native Contracts to be updated or receive new functions
6 participants
@shargon @Jim8y @AnnaShaleva @roman-khimov @vncoelho @superboyiii